Abe404 / RootPainter3D

RootPainter3D: Interactive-machine-learning enables rapid and accurate contouring for radiotherapy
GNU General Public License v3.0
19 stars 10 forks source link

segment folder function not working for dev_mc branch. #5

Closed Abe404 closed 2 years ago

Abe404 commented 2 years ago

A problem has been reported with segment folder not working in the dev_mc branch.

Looks like the following is causing the issue:

segment_folder.py", line 87, in segment_folder assert seg_classes[0][0] == 'Background' AssertionError

I will work on first reproducing this issue and then working on a solution (it's probably quite simple to fix).

Abe404 commented 2 years ago

I now ran into a problem where images can be 'too small' as they are smaller than the automatically found patch size on the server.

/trainer/model_utils.py", line 264, in segment_3d assert image.shape[2] >= in_tile_shape[2], f"{image.shape[2]},{in_tile_shape[2]}" AssertionError: 212,244

I need to update the server to handle images smaller than the default patch size.

Abe404 commented 2 years ago

Now solved (I believe) with https://github.com/Abe404/RootPainter3D/commit/1f8e2874ec507d3041c62cb2314e8a22132e4224 and https://github.com/Abe404/RootPainter3D/commit/400149a11462e8c8360288cacb00bd8cb83e7a59 Waiting on feedback from user testers.

Abe404 commented 2 years ago

I noticed that the segment folder progress bar does not update. I will work on a fix.

Abe404 commented 2 years ago

Segment folder progress bar now fixed to work for multiclass output with the following commit:

https://github.com/Abe404/RootPainter3D/commit/3e4aa16bb1eaa4e6009f5bc70c843e3a8f72da0c

Abe404 commented 2 years ago

It worked with my own tests and I haven't received any more complaints from the users so I will close this for now.