search

Abe404 / root_painter

RootPainter: Deep Learning Segmentation of Biological Images with Corrective Annotation
https://nph.onlinelibrary.wiley.com/doi/full/10.1111/nph.18387
Other
58 stars 17 forks source link

Create dataset should try to complete even if it fails for some images #38

Closed Abe404 closed 2 years ago

Abe404 commented 2 years ago

Describe the bug Creating a dataset doesn't complete if there is an issue with a single image.

To Reproduce Steps to reproduce the behavior:

  1. Create a training dataset where one of the images in the source dataset contains a problematic image (for example a corrupted file).
  2. Observe that the software crashes and doesn't complete the creation of the full training dataset.

Expected behavior Only the single image with the problem should not be processed. The dataset should otherwise be created normally. The error with the single image should be displayed at the end with the number of images that failed to process also displayed.

Abe404 commented 2 years ago
Screenshot 2022-04-18 at 20 09 27

This has now been implemented. See: https://github.com/Abe404/root_painter/commit/8fd385ad103bb34539f5ceb1d8867d99300c78bd

I will close the issue. The next steps are to rebuild the installers and make a release.