AbedElazizShe / LightCompressor

A powerful and easy-to-use video compression library for android uses MediaCodec API.
Apache License 2.0
537 stars 116 forks source link

[Request] - Can videoBitrateInMbps be a double or be changed to videoBitrateInBps? #177

Open waterdrake opened 1 year ago

waterdrake commented 1 year ago

In the Configuration object videoBitrateInMbps is an int. It would be really helpful to be able to pass in a more fine grained bitrate. Two possible solutions:

  1. Make videoBitrateInMbps a double.
  2. Keep bitrate as int but instead of mbps use bps. I would personally prefer this because on iOS the bitrate is passed around as a int bps. You can then have parity between the platforms and specify a as fine grained a bitrate as you want.

Thank you!