Abedalkareem / games_services

A Flutter plugin to support game center and google play games services.
122 stars 49 forks source link

Add PlayerData class to return more score holder details. #152

Closed theLee3 closed 9 months ago

theLee3 commented 9 months ago

Adds a PlayerData class to return inside a LeaderboardScoreData object. The PlayerData object includes the previously available displayName & iconImage and adds playerID & teamPlayerID.

teamPlayerID is only available on iOS/macOS and playerID can be null on Android due to privacy settings.

scoreHolderDisplayName & scoreHolderIconImage getters are added to LeaderboardScoreData to maintain backwards compatibility.

Closes #146.

PacifistaBot commented 9 months ago
Warnings
:warning: Please update the `CHANGELOG.md` file.
:warning: Please update the documentation in the `docs/` folder.

Generated by :no_entry_sign: dangerJS against 83f014aec988ebd895901fcd5c01b8b680381a17

egonbeermat commented 5 months ago

I think proguard-rules.pro requires this:

-keep class com.abedalkareem.games_services.models.PlayerData { <fields>; }

Without this, the data returned cannot be parsed due to the mangling done by a release build. Discovered the issue during Open Testing in the Play Console, but was fine during local Debug builds. Resolved by adding the above.