Abedalkareem / games_services

A Flutter plugin to support game center and google play games services.
118 stars 48 forks source link

Remove Google Auth api dependency. #170

Closed theLee3 closed 1 month ago

theLee3 commented 1 month ago

After reviewing the code, it seems that the auth api is no longer necessary after migrating to GPG v2. This removes the dependency on the library as well cleaning up the Auth class, removing the sign in result listener redundancy. This may even resolve some reported issues related to the sign in process/result.

egonbeermat commented 1 month ago

LGTM on a quick test. I cloned these changes locally, and built my app. Ran a test on emulators API level 29, 30 and real device API level 33. With an account already signed in to Play Games, app started and signed in, Play Games functionality (load leaderboards, submit score, view achievements) worked. Then closed app, signed out of all games via Play Games, ran the app again and was prompted for signin account, which it accepted and functionality worked as expected.