Abedalkareem / games_services

A Flutter plugin to support game center and google play games services.
122 stars 49 forks source link

Add optional `forceRefresh` parameters to load methods on Android. #173

Closed theLee3 closed 2 months ago

theLee3 commented 2 months ago

As per the docs, regarding forceReload:

If true, this call will clear any locally cached data and attempt to fetch the latest data from the server. This would commonly be used for something like a user-initiated refresh. Normally, this should be set to false to gain advantages of data caching.

Currently, we provide no forceReload option for leaderboards, causing outdated data from the cache to be returned at times. We also always force reload data for both achievements & saved games. As noted in the docs, this should not be the default. Therefore, we should defer to the devs to select the appropriate call for all of these methods.

This has no effect on iOS/MacOS as there is no caching mechanism to invalidate.

PacifistaBot commented 2 months ago
Fails
:no_entry_sign: Flutter analyzer failed. Please fix the issues reported by the analyzer. Error: Command failed: flutter analyze 1 issue found. (ran in 7.3s)
Warnings
:warning: Please update the `CHANGELOG.md` file.

Generated by :no_entry_sign: dangerJS against 0a63a7731d7bb3d8645eb9030baf2baecbb2dc0c

theLee3 commented 2 months ago

Just updated the docs as well in this PR.