search

AbelHeinsbroek / chartjs-plugin-crosshair

Crosshair plugin for ChartJS
https://chartjs-plugin-crosshair.netlify.com/samples/
MIT License
145 stars 87 forks source link

chore: update chart.js version in peer dependencies #115

Closed Arantiryo closed 11 months ago

Arantiryo commented 1 year ago

The plugin seems to work correctly with Chart.js 4.x so the PR updates peerDependencies to reflect that.

igorlukanin commented 1 year ago

@AbelHeinsbroek Could you please take a look at this PR?

nategrift commented 11 months ago

This doesn’t seem compatible with the latest version on chartJs as there are some breaking changes released in version 4. To be specific, the destroy has been replaced and therefore is not run when destroying the plugin.

https://www.chartjs.org/docs/latest/migration/v4-migration.html#specific-changes

nategrift commented 11 months ago

Thanks for trying to bump it, it did create some breaking changes, so I fixed those in a separate PR. https://github.com/AbelHeinsbroek/chartjs-plugin-crosshair/pull/122