Open codepathreview opened 2 years ago
AbelKel
commented
2 years ago Hello Codepath,
I have resubmitted a GIF showing all the core features. I did not know that I was supposed to record the "No internet found issue." Apologies for the mistake! You can access my new GIF here or look at my recent resubmission on my code path portal. I will also be updating the read me file with my new video that shows all the features. Thank you for the feedback!
AbelKel
commented
2 years ago Hello Codepath,
I have resubmitted a GIF showing all the core features. I did not know that I was supposed to record the "No internet found issue." Apologies for the mistake! You can access my new GIF here https://media.giphy.com/media/JqBpvxbC3vQvhXWKXV/giphy.gif or look at my recent resubmission on my code path portal. I will also be updating the read me file with my new video that shows all the features. Thank you for the feedback!
On Fri, Jun 17, 2022 at 11:21 PM CodePath Reviewers < @.***> wrote:
Nice work! The purpose of this project was to continue learning Objective-C and the Cocoa Touch (iOS) framework. You should be comfortable creating table views (one of the most common views in iOS) and working with array of dictionaries created from JSON (in this case from the Movies Database API).
A key part of these projects is that you work to polish the visuals and the small UI / UX touches. Developing your design sense is an important part of being a mobile engineer. You'll find that perfecting the UI / UX will often lead to interesting technical challenges as well because the libraries may not behave exactly as you want them to, so you'll have to learn how to achieve the effect that you want. A few other things to note:
- Did you use groups to organize your source files? It's pretty common to organize your source files into Groups https://developer.apple.com/library/ios/recipes/xcode_help-structure_navigator/articles/Creating_a_Group.html, especially for larger projects. You can organize by type of class (i.e. View Controllers, Views, etc) or for larger apps by functionality (i.e. Home Screen, Search Screen, etc).
- Did you minimize the number of public methods and properties in your classes? You should always try to minimize the number of properties and methods that are in the header files. Only expose what you have to, e.g., properties and methods that must be accessed by other classes.
- Did you properly set the Content Mode for your ImageViews? By default the UIContentMode https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIView_Class/#//apple_ref/c/tdef/UIViewContentMode will stretch the image to match the dimensions of the image view, which is probably not what you want. The most common combination is to use Aspect Fill combined with clipping subviews.
We have graded your work, and it looks like the following features are not reflected on your GIF walkthrough:
- User sees an error message when there's a networking error.
The GIF helps us to make sure we don't miss any required or optional stories you have completed. We highly suggest that you provide us with a GIF that completely shows all the features you have implemented.
— Reply to this email directly, view it on GitHub https://github.com/AbelKel/Flixter/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW634OXESVNWZOO5DNXYHFDVPVTGDANCNFSM5ZEIOUOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Nice work! The purpose of this project was to continue learning Objective-C and the Cocoa Touch (iOS) framework. You should be comfortable creating table views (one of the most common views in iOS) and working with array of dictionaries created from JSON (in this case from the Movies Database API).
A key part of these projects is that you work to polish the visuals and the small UI / UX touches. Developing your design sense is an important part of being a mobile engineer. You'll find that perfecting the UI / UX will often lead to interesting technical challenges as well because the libraries may not behave exactly as you want them to, so you'll have to learn how to achieve the effect that you want. A few other things to note:
We have graded your work, and it looks like the following features are not reflected on your GIF walkthrough:
The GIF helps us to make sure we don't miss any required or optional stories you have completed. We highly suggest that you provide us with a GIF that completely shows all the features you have implemented.