learning commons pages need to be intergrated

[gjwehnes]

content has been added in learning-commons-integration branch (as a .ZIP file)

-pages and content need to be modified to fit our template -decision needs to be made on where in the website these pages will be placed. they will either be their own supercategory (learning commons) or as a category under student services. as there will eventually be substantial content here, I would recommend the former, but suggestions are welcome.

[thirstyice]

Area. Student services is too big already We'll need to get rid of something else though, for it to fit

[thirstyice]

Modifications aren't going to cut it. This has to be re-done from scratch.

[nemeulenbroek]

@thirstyice, please leave this for others to do. We have a couple people from my comp sci class who are looking to get in by foing this as a pull request and we need to teach them. We can then help them along from the comments

[thirstyice]

I think this is too big to leave to someone who is unfamiliar with editing the website. Have you looked in the zip?

[nemeulenbroek]

I have. We have multiple people who want to do it, and there's very few issues that can be worked on like this at the moment. We have to teach them somehow and at least now there's the opportunity to monitor it

[thirstyice]

I will watch them like a hawk

[nemeulenbroek]

I know you will. I was counting on that. Just be gentle in the comments

[dominic-demierre]

hi all, in the Library Web Page html mr. roberts attempts to link both the Library Pathways submenus to a folder containing multiple pdfs. not entirely sure of his intentions there, but is the best way to implement those pdfs by using iframes?

[nemeulenbroek]

I would say so, just as long as it makes sense content wise (as in they're not obviously meant to a part of a different section)

[thirstyice]

When is work going to start on this?

[nemeulenbroek]

Currently in progress

[thirstyice]

Where?

[nemeulenbroek]

In a fork

[thirstyice]

None of the forks have any changes

[nemeulenbroek]

Ah. I'm not entirely sure then. I know there's progress being made however as I heard about it in comp sci

[thirstyice]

Can it be pushed so that it can be reviewed?

[nemeulenbroek]

I'll ask

[dominic-demierre]

progress on the first draft is being made at a good rate. iirc there are only two unfinished pages remaining (both Library Pathways links)--do you want me to just push it without those two?

[nemeulenbroek]

I think that would be a good idea, and then we can check it out before anything is set in stone

[thirstyice]

For future reference, big changes like this should probably be done over several small commits, so that if there is a problem we can revert only that commit, and also to be more descriptive about what exactly was done.

[dominic-demierre]

took me more fumbling with the UI than i care to admit but the changes are now on my fork, under the learning-commons-integration branch. and you're absolutely right, thirstyice, in future i'll go about big changes like that. cheers for the advice

[nemeulenbroek]

Doesn't appear to have been pushed as of now

[dominic-demierre]

it's there for me--were you checking under the learning-commons-integration branch?

[nemeulenbroek]

Never mind. I'm doing this on my phone, so functionality is reduced

[dominic-demierre]

ok, phew. it's still possible i'm using this website correctly

[nemeulenbroek]

Yea, you're good to go

[thirstyice]

Ok, reviewing the code here are some issues:

• [ ] Section headers should be <h3>, not <h2><u> here, for example
  Guideline reference
• [ ] In fact, generally the headers need some review
• [ ] External links should be marked "(External)"
  Guideline reference
• [ ] Links shouldn't link across areas
• [ ] "Read this first!" is not descriptive enough as a menu item

Additionally, the table in learning-commons.html stands out in terms of style. Nothing is really wrong with it, but I could tell you copy-pasted it from the original html before I even looked at the code.

[dominic-demierre]

whoops, you're absolutely right! i've fixed the section header and will be awaiting further instructions

[thirstyice]

Further instructions: Remember to commit and push after making changes

[dominic-demierre]

ok, pushed and commited it and now all of your main issues should be fixed. not sure what to you want me to do with the table in learning-commons.html, although i do agree that it stands out. any suggestions?

[thirstyice]

I don't see your push anywhere

[nemeulenbroek]

Check the network graph

[thirstyice]

I did; there's the original push, but no updates

[nemeulenbroek]

The update showed up for me... I'm not really sure what happened

[dominic-demierre]

sorry, i made a mistake there. it's definitely been pushed now

[thirstyice]

The work experience section could probably be merged with the career center page in student services. (Consult @gjwehnes ) Staff contact info could be at the top of the learning commons main page. The learning commons main page could be grouped into tabs (see student services) The link to New arrivals/dvds shouldn't exist if we have nothing to link to.

[thirstyice]

Is work still happening on this?

[dominic-demierre]

work is still happening, yes, although it did come to a halt during spring break. sorry for the lack of updates--i've incorporated most of the changes you suggested up there in a commit on my master branch, in case you're interested in seeing what's been done. i believe @gjwehnes will be showing those same changes to mr. roberts sometime in the near future, to see what gets his approval and what doesn't. also, whether or not to merge pages with the career center is a tricky decision, as i'm sure you're aware, so we've been trying to get everything else perfect before we worry about that.

[gjwehnes]

all changes have been merged into learning-commons-integration branch (https://github.com/thirstyice/abe-site/commit/ab71dfd01974dd4560c85538693c41ce3cad35b1)

As mentioned, this should still be reviewed by 1) our client (mr. Roberts) and 2) all members of this team.

The hope is for this to go live by the end of this week (24 April)

[Bigbobo558]

I have given the pages created by Mr. owmygreenmatter and I think the design along with the functionality of the web pages are quite well done. In my personal opinion, these should be added to the official website.

[gjwehnes]

Merged into master branch :-)

Well done @owmygreenmatter for sticking with it, and to all for your support and guidance, This was as much a learning experience in workflow (i.e. how to develop and integrate a fairly major addition to our site in parallel to the ongoing maintenance.

[thirstyice]

Not finished yet. See #143

[dominic-demierre]

@gjwehnes thank you very much, i'm really glad to see it finally go up.

@thirstyice i'm sorry but i don't follow; i know you made a separate branch but i'm not sure what should happen there. could you please elaborate?

[thirstyice]

The new branch included only those commits which were relevant to the implementation of learning-commons.