search

Aberhart-school / abe-site

The website of William Aberhart high school
http://schools.cbe.ab.ca/b829/aberhart/
GNU General Public License v3.0
7 stars 8 forks source link

School Council to move to home context menu #123

Closed gjwehnes closed 9 years ago

gjwehnes commented 9 years ago

As per request from admin.

This may also allow us to rid the nav bar of the "about" category (or at least rename it to contact). See discussion in issue #121

At the same time the folder and file names should be updated to reflect that the Parent Council is now named the School Council

nemeulenbroek commented 9 years ago

...are we allowed to say that we called this a long time ago? I think it was at the beginning of the year that I wanted to do this. Is my branch where I already implemented this still around?

thirstyice commented 9 years ago

It was deleted. I restored it. The branch was made before resizing content or better areamenus were implemented, so updates are required. PR #88

And yes. We called it.

nemeulenbroek commented 9 years ago

If we try to merge, won't it not affect the look? I'm not sure how much the merge will want to change

thirstyice commented 9 years ago

There are merge conflicts anyway. Starting from scratch is the way to go. With the new areamenu importation, all you have to do is move the files and cut/paste the areamenu links and it's done.

nemeulenbroek commented 9 years ago

It wasn't that simple when I did it originally

thirstyice commented 9 years ago

No, which is why there had to be a separate branch, and why starting from scratch would be easier than modifying the existing branch.

nemeulenbroek commented 9 years ago

OK. Go for it