Aberhart-school / abe-site

The website of William Aberhart high school
http://schools.cbe.ab.ca/b829/aberhart/
GNU General Public License v3.0
6 stars 8 forks source link

Max-width slider #137

Closed gjwehnes closed 9 years ago

gjwehnes commented 9 years ago

EDIT by @thirstyice: This issue was originally only about max-width

With the dynamic resizing, this was not addressed. We are still getting complaints that our page is too wide on certain monitors.

Will provide further clarifications tomorrow (i.e. specs for max_width); added now so that it does not get lost in the shuffle.

thirstyice commented 9 years ago

There is one: it's 1900px, see #122

thirstyice commented 9 years ago

How about a slider somewhere that would allow people to manually adjust max-width?

nemeulenbroek commented 9 years ago

Ohhhhhhhh, I like that... I don't think that would be possible to store for each individual user though unless you got really fancy with posts and gets

nemeulenbroek commented 9 years ago

Or there's some way you can use cookies in jquery

thirstyice commented 9 years ago

https://github.com/js-cookie/js-cookie

nemeulenbroek commented 9 years ago

....I needed this a long time ago, could not find it

thirstyice commented 9 years ago

What scale should the slider have? Where should we put it?

nemeulenbroek commented 9 years ago

Over top or under external links? And then it just fills the right hand side, we can have a pop up explaining what it does that's controlled by a booleanViewed in the cookie, and then it can toggle from our old min width to our current max width? That's probably what I would do. And then default we can maybe set to 1600? Any objections to that?

thirstyice commented 9 years ago

I suspect the slider might be too small there, but we'll see EDIT: Due to logistics, we can't include the slider in a universal document. Any other suggestions?

Bigbobo558 commented 9 years ago

If the max width could be set to 1080 and a background be set for anything beyond that, I suspect that would look pretty great. It would give quite a bit of width for viewing, while not stretching it too much. Just an idea.

thirstyice commented 9 years ago

The background would require that we add an element to all the webpages in the repo. Why 1080px? That's smaller than an iPhone 5 in landscape.

nemeulenbroek commented 9 years ago

Also, we took away the width that small specifically so that we could stretch it and make it feel less cramped and to accommodate different screen sizes. That would also completely negate all the effects of the changes to the website as it's only 20px wider that what we had before we implemented the dynamic layout. As for suggestions, just make max width >1600px? Other than that, we could include the slider in a separate page and link to it as a kind of setting.

nemeulenbroek commented 9 years ago

And the background before was quite frankly one of the most common complaints that we got about the design in the website survey

thirstyice commented 9 years ago

It would be a little weird to have a page with just a slider. Maybe under the news?

nemeulenbroek commented 9 years ago

Well, theoretically we could do a settings page and then have more options as well, like backdrops colour or something. Maybe that's in the future though. For now, I don't see anything wrong with it being under news as long as it doesn't span the full div

thirstyice commented 9 years ago

What do you mean "span the full div?" Like be the full width of content? Why would that be bad?

nemeulenbroek commented 9 years ago

I think it would be too big. I'd make it like 50% width, because otherwise you'll have to slide the pointer too far too adjust it properly

thirstyice commented 9 years ago

I see. Probably a pixel width would be better though so that the size doesn't depend on the very setting you are changing. I could see that causing problems.

nemeulenbroek commented 9 years ago

Good catch

thirstyice commented 9 years ago

Work is in width-slider. Also, this is really cool. Playing highly recommended.

thirstyice commented 9 years ago

I don't see this being useful on a mobile interface, so the slider will be hidden on those OSs

thirstyice commented 9 years ago

Done.

thirstyice commented 9 years ago

Any further discussion will be moved to pr #148 Closing.