search

Abhayakara / mdnsresponder

mDNSResponder work-in-progress
Other
20 stars 8 forks source link

Ignore -Wdate-time warning when generating version string #12

Closed twasilczyk closed 3 years ago

twasilczyk commented 3 years ago

In this commit I followed the fix from dnssd_clientlib.c. However, the warning sound reasonable (it makes reproducible builds possible, which is a part of chain of trust and important security measure), so I would advise for removing __DATE__ and __TIME__ macros from the version string. Please let me know and I will update this commit if you agree.

I also found a bunch of other uses of this macro in several other files, so it would be worthy to fix them too. However, I didn't get to building them for my OS, so I couldn't verify the source changes myself.

twasilczyk commented 3 years ago

Hi, any comments on this one (and the other PR's too btw)? Again, I think removing the date from these strings would be ideal.

Abhayakara commented 3 years ago

Thanks for the reminder. The team discussed this, and we agree to remove the DATE and TIME macros.

Abhayakara commented 3 years ago

This pull request has been merged to the internal repo and was included in the mDNSResponder-1587 commit.