AbhiPatel10 / AISKCON-CONSTRUCTION

https://abhipatel10.github.io/AISKCON-CONSTRUCTION/
56 stars 185 forks source link

Added contribution.md file #345

Closed VyjayantiN closed 1 year ago

VyjayantiN commented 1 year ago

Summary

Added a Contribution.md file to provide guidelines for contributing to the project. This file will help new contributors understand the process and requirements for making contributions. No dependencies are required for this change.

Fixes

Fixed the issue #341

Type of change

Please select the relevant option.

Checklist

Please tick the relevant options.

VyjayantiN commented 1 year ago

@AbhiPatel10 @Neilblaze Please check this out.

kartikayasija commented 1 year ago

@VyjayantiN Fix this issue in the Footer ,

image image
VyjayantiN commented 1 year ago

@kartikayasija I didn't make any improper changes to the footer. Are you asking me to look into them as a mentee or did I make any mistake? However, I would love to change that.

VyjayantiN commented 1 year ago

@Neilblaze @kartikayasija Please check this out!!

kartikayasija commented 1 year ago

Just remove list-style: circle, then I'll merge.

image
VyjayantiN commented 1 year ago

@kartikayasija please check out the merged pull request #355 regarding the footer. I changed it long back and you already merged it @kartikayasija . This is pr #345 regarding the contribution.md Please check out both the PRs to avoid confusions!!

Neilblaze commented 1 year ago

@VyjayantiN It would be advisable to include the specific #ID linking to the corresponding issue for every PR you submit.

VyjayantiN commented 1 year ago

I have added the issue number in the PR. Please check that out. I am sorry for the inconvenience. Sorry @kartikayasija @Neilblaze.

kartikayasija commented 1 year ago

@kartikayasija please check out the merged pull request #355 regarding the footer. I changed it long back and you already merged it @kartikayasija . This is pr #345 regarding the contribution.md Please check out both the PRs to avoid confusions!!

Yes, the footer issue was resolved previously, but you have again commited that line in this PR, so when I will merge it, the issue will occur again. Just remove that one line instead of writing replies.

VyjayantiN commented 1 year ago

@kartikayasija which one line? I didn't understand

Neilblaze commented 1 year ago

@VyjayantiN 👇🏼 https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/blob/b85e1a656d73b18c0ef21dd4f609afd1eae915b1/aboutUs/style.css#L18

VyjayantiN commented 1 year ago

@Neilblaze Okay!!

VyjayantiN commented 1 year ago

I resolved that but it is showing that there are conflicts to merge. I am not understanding why it happened.

VyjayantiN commented 1 year ago

Thank you @Neilblaze 🙏🙏🙏

kartikayasija commented 1 year ago

Resolve conflicts.