AbhiPatel10 / AISKCON-CONSTRUCTION

https://abhipatel10.github.io/AISKCON-CONSTRUCTION/
56 stars 185 forks source link

Added close button to the chatbot #348

Closed VyjayantiN closed 1 year ago

VyjayantiN commented 1 year ago

Summary

Added close button to the chatbot This pull request adds a close button to the chatbot, allowing users to close the chatbot window when pressed. The close button provides a more intuitive way for users to exit the chatbot interface.

Fixes # (issue)

Fixed the issue of the chatbot not having a close button

Type of change

Checklist

Screenshots

image

VyjayantiN commented 1 year ago

@Neilblaze @AbhiPatel10 Please look into it

VyjayantiN commented 1 year ago

Thanks @Neilblaze !! But could you please add the tag - GSSOC'23 for this issue!! I am a GSSOC'23 contributor.

Neilblaze commented 1 year ago

@VyjayantiN It's currently under review. Once it's approved, I'll add that label don't worry!

kartikayasija commented 1 year ago

@VyjayantiN Make the close button more attractive.

VyjayantiN commented 1 year ago

@kartikayasija How are these? Please select one. image

image

image

VyjayantiN commented 1 year ago

@kartikayasija could you please add the tag - GSSOC'23 for this issue!!

kartikayasija commented 1 year ago

I think second or third one would be good. What say?

VyjayantiN commented 1 year ago

Yes anything is okay for me. I think third one is decent. @kartikayasija

kartikayasija commented 1 year ago

Go for it @VyjayantiN

VyjayantiN commented 1 year ago

Done @kartikayasija!! Please add labels and check the PR!! image

kartikayasija commented 1 year ago

After the chatbot is closed, it is not opening again. Solve this. There should be animation when it closes. Also vertically align this close button in center. Do these changes, I'll add the labels don't worry.

https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/assets/115306535/8ca8cc5b-d30e-4a00-95df-503d643abe32

VyjayantiN commented 1 year ago

@Neilblaze @kartikayasija Please check this out. I made this two days ago. Also , do please add the GSSOC'23 label.

Neilblaze commented 1 year ago

@VyjayantiN I see that you have a pending review. Awaiting @kartikayasija's response.

kartikayasija commented 1 year ago

@VyjayantiN have you solved these issues?

After the chatbot is closed, it is not opening again. Solve this. There should be animation when it closes. Also vertically align this close button in center. Do these changes, I'll add the labels don't worry.

Recording.2023-06-11.234636.mp4

VyjayantiN commented 1 year ago

@kartikayasija I will check that out. Give me some time.

kartikayasija commented 1 year ago

@VyjayantiN Are you working on it?

VyjayantiN commented 1 year ago

@kartikayasija Yes

VyjayantiN commented 1 year ago

@kartikayasija I finished. Please check that out!!

VyjayantiN commented 1 year ago

@kartikayasija Please look into it.