AbhiPatel10 / AISKCON-CONSTRUCTION

https://abhipatel10.github.io/AISKCON-CONSTRUCTION/
55 stars 183 forks source link

Fix Navbar #352

Closed rolikaagarwal closed 1 year ago

rolikaagarwal commented 1 year ago

image

Fix this issue in the navbar. When we scroll down the navbar is showing unexpected behaviour.

Neha5679 commented 1 year ago

As a part of GSSOC'23, I would like to work on it. So, can you provide me.

Diya28-mehra commented 1 year ago

I want to work on this issue. Please assign me this

kartikayasija commented 1 year ago

Go ahead @Neha5679 , Try to complete it asap.

ritik48 commented 1 year ago

hi @Neha5679, are you still working on this ?

Neha5679 commented 1 year ago

I tried but the issue is not resolved yet. Their is no issue during scroll up. But issue comes during scroll down. Already use sticky and top 0 but their is margin on top during scroll down.

On Thu, 15 Jun, 2023, 11:07 pm Ritik Raj, @.***> wrote:

hi @Neha5679 https://github.com/Neha5679, are you still working on this ?

— Reply to this email directly, view it on GitHub https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/issues/352#issuecomment-1593481626, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64MFKR7I2CST2BAZHJMI63XLNB4HANCNFSM6AAAAAAZB2RH7A . You are receiving this because you were mentioned.Message ID: @.***>

ritik48 commented 1 year ago

@Neha5679 actually it's happening due to position: sticky on navBar1. I searched about it and found out sticky has buggy jump behavious. So I changed position: sticky to fixed and then it got resolved.

Neha5679 commented 1 year ago

Yes, it's working but then more issues comes after that so need to resolve navbar width and h1 in hero section. I done it, can you go through once maybe it resolved now

On Fri, 16 Jun, 2023, 11:17 am Ritik Raj, @.***> wrote:

@Neha5679 https://github.com/Neha5679 actually it's happening due to position: sticky on navBar1. I searched about it and found out sticky has buggy jump behavious. So I changed position: sticky to fixed and then it got resolved.

— Reply to this email directly, view it on GitHub https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/issues/352#issuecomment-1594139212, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64MFKQVUOPQCESFJDM6KULXLPXOVANCNFSM6AAAAAAZB2RH7A . You are receiving this because you were mentioned.Message ID: @.***>

ritik48 commented 1 year ago

@Neha5679 Actually I have already created a pr for this issue. Let's see if it gets merged. You can see the required code changes I made in this pr #373

kartikayasija commented 1 year ago

@Neha5679 @ritik48 This bug is being caused by background attachment properties of Why choose Us Section. Try to fix that, the sticky position of navbar is totally find.

ritik48 commented 1 year ago

@kartikayasija thanks for the help. I have updated my pr, please review it.