AbhiPatel10 / AISKCON-CONSTRUCTION

https://abhipatel10.github.io/AISKCON-CONSTRUCTION/
55 stars 184 forks source link

animated back to top added #468 #473 {video attached} #496

Closed harshita-2003 closed 1 year ago

harshita-2003 commented 1 year ago

Summary

Back to top button added which starts animating only on hover , and it shows only when scrolled down

Fixes #468

as you mentioned the points in #473

Type of change

Please select the relevant option.

Checklist

Please tick the relevant options.

Screenshots

https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/assets/119532943/1c2cce9a-0786-4f65-8857-1b2c89342abb

Additional context

Add any other context about the pull request here.

harshita-2003 commented 1 year ago

@Neilblaze @kartikey129 @piyushlakheda added the back totop which only shows up on scroll and only animated on hover

Do acknowledge and add the level tag and gssoc

harshita-2003 commented 1 year ago

@Neilblaze just want to confirm this task will be come under level 3 I believe as its about adding the functionality

Neilblaze commented 1 year ago

@harshita-2003 I don't think level-3 will be a better fit for the revised PR, since it's not a custom feature, that's being incorporated into the app. It's just a minor CSS upgrade.

harshita-2003 commented 1 year ago

Earlier it was not functional as not returning to top , I will accept anyway but would be glad it would be atleast level 2 😊

Neilblaze commented 1 year ago

I will accept anyway but would be glad it would be atleast level 2

@harshita-2003 alright, I'll update the current with a level-2 tag.

Neilblaze commented 1 year ago

Now, make the changes accordingly.

harshita-2003 commented 1 year ago

Yes , it is completely functional now i,e., it will return to top and animates on hovering You can merge this PR.

harshita-2003 commented 1 year ago

@Neilblaze can you look into this hovering effect of faq section , it matches with blue theme of the site

https://github.com/AbhiPatel10/AISKCON-CONSTRUCTION/assets/119532943/61f78dd2-5d03-4b47-84ed-2f57ff0033c3