search

Abhiek187 / ez-recipes-ios

Easy recipes finder iOS app
MIT License
0 stars 0 forks source link

Deployment Target: iOS 16 #43

Closed Abhiek187 closed 8 months ago

Abhiek187 commented 8 months ago

I updated the deployment target to iOS 16 and removed all deprecated code associated with iOS 15. Most of the changes involved migrating from NavigationView to NavigationStack or NavigationSplitView, with plenty of navigationDestination sprinkled in.

And since we're keeping the version of Package.resolved to 3, I configured Fastlane to use Xcode 15.3 using xcodes and updated the docs accordingly.

Abhiek187 commented 8 months ago

It seems like the the roles have reversed. Android tests are now quick and consistent and iOS tests are slow and flaky! Let's see if yeetd will improve the performance, based on https://github.com/actions/runner-images/discussions/8651#discussioncomment-7393444. I won't include this in the Mermaid diagram since I'm hoping this is a temporary workaround.

Abhiek187 commented 8 months ago

[04:16:24]: ▸ ::error file=/Users/runner/work/ez-recipes-ios/ez-recipes-ios/EZ Recipes/EZ RecipesTests/HomeViewModelTests.swift,line=67:: testGetRandomRecipeFail, Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "Fetch a random recipe". [04:16:26]: ▸ ::error file=/Users/runner/work/ez-recipes-ios/ez-recipes-ios/EZ Recipes/EZ RecipesTests/HomeViewModelTests.swift,line=47:: testGetRandomRecipeSuccess, Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "Fetch a random recipe".

yeetd didn't help. Unit tests shouldn't exceed 1s. The longest they usually take is 0.05s to probably warm up. But I did notice a legitimate issue on iPads when using MultiPicker to search for recipes, so I'll need to fix that.