search

Abhinandan-Kushwaha / react-native-gifted-charts

The most complete library for Bar, Line, Area, Pie, Donut, Stacked Bar and Population Pyramid charts in React Native. Allows 2D, 3D, gradient, animations and live data updates.
https://www.npmjs.com/package/react-native-gifted-charts
MIT License
701 stars 147 forks source link

Type checks failing #546

Closed abpbackup closed 4 weeks ago

abpbackup commented 6 months ago

Problem when having Typescript with strict mode and noImplicitAny: false

image

Solution: add missing types

image

This goes for all the components:

image
Abhinandan-Kushwaha commented 6 months ago

Hi @abpbackup, I am working on adding types. Should be ready within a week.

Darkhorse-Fraternity commented 6 months ago

Any update on this issue?

lakardion commented 5 months ago

Hi @abpbackup, I am working on adding types. Should be ready within a week.

Thanks, Just facing this so I'll turn off typecheck in our rn project for the time being

cliveportman commented 5 months ago

Hi @abpbackup. If you have a local branch and don't have time to finish, I'd be happy to pick it up if you want?

Abhinandan-Kushwaha commented 4 weeks ago

Hi @abpbackup @Darkhorse-Fraternity @lakardion @cliveportman react-native-gifted-charts is now shipping compiled js files instead of ts files from version 1.4.22 onwards. This should fix all type related issues. 🎉