Closed james-cohen closed 2 months ago
Hi @james-cohen I will be merging the pending PRs this week, and will also try to release a new version of the library with fully typed code. Sorry for such long delay.
Hi @Abhinandan-Kushwaha ,
thanks for the great library! I'm also waiting for the update 🙏
Hi @james-cohen @pinuts-SebastianGolbert
react-native-gifted-charts
is now shipping compiled js files instead of ts files from version 1.4.22
onwards. This should fix all type related issues. 🎉
@Abhinandan-Kushwaha Thank you for the fix! If I'm not mistaken, gifted-charts-core also needs a similar fix.
I forgot to mention that I have been using a workaround for these issues:
// TODO: Change to module import when the next library release is available
const giftedCharts = require('react-native-gifted-charts');
const PieChart = giftedCharts.PieChart;
Together with a declaration of the library as empty module
// TODO: Delete when when the next library release is available
declare module 'react-native-gifted-charts';
created an issue https://github.com/Abhinandan-Kushwaha/gifted-charts-core/issues/31
Hi @stereodenis Thanks for reporting this issue.
It has been fixed with this PR- https://github.com/Abhinandan-Kushwaha/gifted-charts-core/pull/33
Using this package results in type errors due to undeclared types when using
tsc
. We have had to turn off type checks in our CICD pipeline in order to use this package, but this has now caused bugs in our app so I want to draw attention to the issue.I have seen that the issue has been raised multiple times and there are multiple PRs offering to resolve the issue.
Can this please be resolved ASAP?
Full error response: