search

Abhinandan-Kushwaha / react-native-gifted-charts

The most complete library for Bar, Line, Area, Pie, Donut, Stacked Bar and Population Pyramid charts in React Native. Allows 2D, 3D, gradient, animations and live data updates.
https://www.npmjs.com/package/react-native-gifted-charts
MIT License
792 stars 153 forks source link

- fixed and returned -1, in getPointerProp, upon releasing the pointer of a line chart [issue #854] #887

Closed jeanniton-mnr closed 3 weeks ago

jeanniton-mnr commented 3 weeks ago

https://github.com/Abhinandan-Kushwaha/react-native-gifted-charts/issues/854

The lines of code that reset the line chart pointer index to -1 upon releasing it were commented on. I have uncommented them.

Now, the pointer index is correctly set to -1 when the pointer is released.

I am asking myself why these lines of code were commented on. Was it during testing or was this in conflict with other feature / behavior?

You can directly install the (npm package) branch with the fixes / removed comments from git using:

npx npm install git+https://github.com/jeanniton-mnr/react-native-gifted-charts.git

Best & happy coding!