AbhinavKartrocket / googlechartwrapper

Automatically exported from code.google.com/p/googlechartwrapper
0 stars 0 forks source link

Separator for extended encoding of series should be comma #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?

Create an XYLineChart with a pair of series and generate URL.

What is the expected output? What do you see instead?

Expected comma for series separator in extended encoding set but get pipe.

What version of the product are you using? On what operating system?

svn trunk

Please provide any additional information below.

Patch attached.

Producing an XYImageLine chart generates invalid URL due to handling of 
auto and extended encoding.  Problem is two-fold:

1. Auto encoding for collections uses separator defined for Auto encoding 
and not the encoder for the appropriate type;
2. Extended encoding should be comma separated as per Google data format 
spec:

http://code.google.com/apis/chart/formats.html#extended

"A string where each two characters is a data point, and each series is 
delimited by a comma."

Original issue reported on code.google.com by chris.lo...@gmail.com on 30 Jan 2010 at 6:56

Attachments:

GoogleCodeExporter commented 8 years ago
This also applies to SimpleEncoding.  With the attached patch in place, then 
amending 
the SimpleEncoder's c'tor to specify a comma resolved the issue:

    public SimpleEncoder() {
        super(TYPE, ",");
    }

Of course, unit test expectations for simplified encoding tests need to be 
adjusted.

Original comment by chris.lo...@gmail.com on 31 Jan 2010 at 12:51

GoogleCodeExporter commented 8 years ago

Original comment by steffan....@outlook.com on 8 Apr 2010 at 12:28

GoogleCodeExporter commented 8 years ago

Original comment by steffan....@outlook.com on 10 Apr 2010 at 7:19