search

AbhishekGhosh / phpmemcacheadmin

Automatically exported from code.google.com/p/phpmemcacheadmin
0 stars 0 forks source link

Allow names in the configuration and reflect that in the gui #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We create our configuration using a script and a config looks like this:

'servers' =>
  array (
    'production-memcached' =>
    array (
      'db7-s0' =>
      array (
        'port' => '28800',
        'hostname' => '10.28.38.70',
      ),
      's0010-s3' =>
      array (
        'port' => '28830',
        'hostname' => '10.28.38.78',
      ),
etc.

So the keys for the server are actual short names. The attached patch changes 
the code so that these names are used everywhere, which makes for our (pretty 
large installation), the tool way more useful because we do not drown in a 
large sea of 10.x.x.x IPs and almost the same ports everywhere. :-) 

It is straightforward. Please apply.

Original issue reported on code.google.com by henn...@schmiedehausen.org on 21 Jan 2012 at 2:13

Attachments:

GoogleCodeExporter commented 9 years ago 
This is actually an enhancement and not a defect, but I was unable to change 
the issue type. :-)

Original comment by henn...@schmiedehausen.org on 21 Jan 2012 at 2:13

GoogleCodeExporter commented 9 years ago 
you probably also want to apply 
https://github.com/hgschmie/phpmemcacheadmin/commit/51981f3b94cf28fde7cefe2d4870
670b50871258

Original comment by henn...@schmiedehausen.org on 22 Jan 2012 at 11:08

GoogleCodeExporter commented 9 years ago 
Hello Henning and thank you for your work :)

I've just merged everything in the tree, i will find some hours until next week 
to finish everything and make a release.

Best

Original comment by eli...@free.fr on 24 Jan 2012 at 5:06

GoogleCodeExporter commented 9 years ago 
Cool. Thanks. I added a minor CSS change because on Google Chrome, the dropdown 
selector on top had white font on white background on Linux.

Original comment by henn...@schmiedehausen.org on 24 Jan 2012 at 9:50

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Fixed in 1.2.2, released today.

Original comment by eli...@free.fr on 30 May 2012 at 1:51