AbhishekKS / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Allow injecting of package private classes #86

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In version 1.0 gin does not allow injecting into package private classes.
It would be very useful for creators of GWT libraries if this were possible
(it would help to keep the API clean). Would it be possible to include this
in a future version of gin?

Original issue reported on code.google.com by dilbert....@gmail.com on 5 Mar 2010 at 6:06

GoogleCodeExporter commented 9 years ago
There is actually a potential way to deal with this, at least for default 
access and
protected classes (I can at the moment not think of a reason to have a private
class). For this we'd have to drop ginjector helper classes into all the 
packages
containing otherwise inaccessible classes and use those helper classes to create
instances. I might look into it this month but no guarantees.

Original comment by aragos on 5 Mar 2010 at 6:24

GoogleCodeExporter commented 9 years ago
Thank you for the very quick reply. At the moment I use such helper classes (I 
call
them providers) but it is ugly and you still can see these helper classes from
outside the package :(.

Original comment by dilbert....@gmail.com on 5 Mar 2010 at 6:31

GoogleCodeExporter commented 9 years ago
Any progress on this issue?

Original comment by dilbert....@gmail.com on 29 Jul 2010 at 3:57

GoogleCodeExporter commented 9 years ago
I get burned every time I move from the real Java world to GWT. Any update on 
this ? Still new, not accepted ?

Original comment by david.nouls on 6 Jun 2011 at 2:47

GoogleCodeExporter commented 9 years ago
I can set it to accepted but that won't change much: While I'd like to see this 
fixed I currently don't have the time for this large change. Patches are 
welcome but be warned that this might be a complex thing to fix.

Original comment by aragos on 6 Jun 2011 at 3:00

GoogleCodeExporter commented 9 years ago
I'm working on this now -- you should see the first patch this week.

Original comment by dburr...@google.com on 6 Jun 2011 at 5:29

GoogleCodeExporter commented 9 years ago
This has been fixed in r241.

Original comment by aragos on 27 Mar 2012 at 12:43