Commands support - Githubissues

AbhishekTimalsina / Type-Nepali

Chrome extension to type in Nepali

https://chromewebstore.google.com/detail/type-nepali/ljbhdpgfoeebgbchbkminmgecialnnen?pli=1

17 stars 4 forks source link

Commands support #7

Open paudsu01 opened 7 months ago

paudsu01 commented 7 months ago

Fixes #6

Add keyboard shortcuts to turn on/off Nepali-typing without opening the extension and clicking the button
A background service worker has been added since the shortcut would need to work whether or not the extension would be open
To do this, the function TOGGLE_TRANSLATE_VALUE from popup.js has been moved to background.js.
Reflect changes in on/off value of button in the popup if keyboard shortcut used while the popup is open

paudsu01 commented 7 months ago

The latest commit 1b93091 isn't related to keyboard shortcuts but rather to issue #8 to handle injection of content-scripts in tabs where it hasn't been loaded yet. Since it involved changes in the TOGGLE_TRANSLATE_VALUE function which was moved to background.js, I just pushed this commit 1b93091 to this branch rather than creating a new branch for a new pull request.

AbhishekTimalsina commented 7 months ago

@paudsu01 sorry that i couldn't respond to your PR. I actually had fixed #6 already. Can you solve issue #8 in the latest code ? I tried to implement your solution but couldn't. (Dont forget to pull the latest code, there are lot of changes)