Abhoryo / APYJsFormValidationBundle

This bundle performs validations of a form in javascript. (i18n compatible and several javascript frameworks supported)
92 stars 23 forks source link

Ticket #15 Introducing to phpunit testing #17

Closed recipe closed 12 years ago

Abhoryo commented 12 years ago

I've activated travis-ci and there is an error with monolog

http://travis-ci.org/#!/Abhoryo/APYJsFormValidationBundle/jobs/2134791

recipe commented 12 years ago

It should have been together with Symfony as Monolog bundle is the part of standard distribution package of symfony 2 . https://github.com/symfony/symfony-standard

Maybe, something is wrong in travis config?

Abhoryo commented 12 years ago

Like you said, monolog is parted of symfony-standard.

recipe commented 12 years ago

Monolog exists only in require-dev env, so we should use it for travis. I do not know how so far. symfony/composer.json

Abhoryo commented 12 years ago

travis installs only symfony/symfony Only twig and doctrine are required. To add other bundles we have to switch to the dev env.

Abhoryo commented 12 years ago

Maybe we can add require-dev, too

Abhoryo commented 12 years ago

I've add the --dev flag to composer.

Abhoryo commented 12 years ago

:( not working too.

recipe commented 12 years ago

Look here. This bundle uses TestBundle too. We need in require-dev section of our bundle.

recipe commented 12 years ago

And they use php composer.phar install --dev instead. You used php composer.phar --dev install

Abhoryo commented 12 years ago

That's not the problem. Monolog is now installed but the kernel doesn't know the namespace.

recipe commented 12 years ago

Ok, it is easier. Looking for other experience Thinking what we do wrong.

recipe commented 12 years ago

I'm going to fix this.

Abhoryo commented 12 years ago

Ok, I let you do this.

recipe commented 12 years ago

Well done http://travis-ci.org/#!/Abhoryo/APYJsFormValidationBundle/builds/2140608

Abhoryo commented 12 years ago

thx.