Abidsyed25 / ScrapQuest

ScrapQuest is your go-to solution for effortlessly extracting data from websites. It's a powerful web scraper built with Next.js, TypeScript, and Puppeteer with Browserless. With ScrapQuest, you can quickly gather valuable information from any website without hassle.

https://scrap-quest.vercel.app/

MIT License

19 stars 36 forks source link

Enhanced the FAQ page #218

Closed ayush-848 closed 3 months ago

ayush-848 commented 3 months ago

Description

Changed background
Restyled the coloring of the accordion
Make the accordion content differentiable
Added hover effects Fixes: #209

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have made this from my own
[x] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

vercel[bot] commented 3 months ago

@ayush-848 is attempting to deploy a commit to the abidsyed25's projects Team on Vercel.

A member of the Team first needs to authorize it.

ayush-848 commented 3 months ago

@Abidsyed25 please check it

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quine-scrap-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2024 10:39am

ayush-848 commented 3 months ago

@Abidsyed25 is there any problem in this???

Abidsyed25 commented 3 months ago

@ayush-848 I am getting errors

Abidsyed25 commented 3 months ago

@ayush-848 please resolve the errors

ayush-848 commented 3 months ago

@ayush-848 please resolve the errors

@Abidsyed25 can you give me the error screenshots?? I cannot find any info

Abidsyed25 commented 3 months ago

@ayush-848 I have pasted error below Failed to compile. ./app/faq/page.tsx:28:42 Type error: Type '{ children: Element[]; type: "multiple"; collapsible: true; className: string; }' is not assignable to type 'IntrinsicAttributes & ((AccordionSingleProps | AccordionMultipleProps) & RefAttributes)'. Property 'collapsible' does not exist on type 'IntrinsicAttributes & AccordionMultipleProps & RefAttributes'. 26 |

27 | <div style={{ width: "750px" }}>

28 | | ^ 29 | {faqs.map((faq, index) => ( 30 | <AccordionItem key={index} value={item-${index}} className="my-4"> 31 | Error: Command "npm run build" exited with 1

ayush-848 commented 3 months ago

@ayush-848 I have pasted error below Failed to compile. ./app/faq/page.tsx:28:42 Type error: Type '{ children: Element[]; type: "multiple"; collapsible: true; className: string; }' is not assignable to type 'IntrinsicAttributes & ((AccordionSingleProps | AccordionMultipleProps) & RefAttributes)'. Property 'collapsible' does not exist on type 'IntrinsicAttributes & AccordionMultipleProps & RefAttributes'. 26 |

27 | <div style={{ width: "750px" }}>

28 |
| ^ 29 | {faqs.map((faq, index) => ( 30 | <AccordionItem key={index} value={item-${index}} className="my-4"> 31 |
Error: Command "npm run build" exited with 1

ok let me fix it give me few minutes

ayush-848 commented 3 months ago

@Abidsyed25 now see

ayush-848 commented 3 months ago

@Abidsyed25 now is it fixed ???????

MastanSayyad commented 3 months ago

@ayush-848 @Abidsyed25 May I know why this PR has level 3 as i can see only accordion answer theme has been changed + css code formatting,

These are the only changes made by the contributor

on the other hand PR #196 which has more enhancements and functionalities has level 2.

Can you pls explain it?

ayush-848 commented 3 months ago

@ayush-848 @Abidsyed25 May I know why this PR has level 3 as i can see only accordion answer theme has been changed + css code formatting,

These are the only changes made by the contributor

on the other hand PR #196 which has more enhancements and functionalities has level 2.

Can you pls explain it?

@MastanSayyad For the issue I did some coloring and positioning part and the level was purely assigned by the admin

MastanSayyad commented 3 months ago

Yes @ayush-848 I'm asking the admin only, as I have been instructed if the page is not created by the Contributor and has only Enhancement then it should be level 1 or level 2,

The difference between the PR #196 and yours is what made me curious.

If you have re-created the entire FAQ page or did any functionality additions (complex one) then the level 3 label is understandable!

I'm just asking as the previous PR has level 2 but as compare to the changes this PR has level 3. So Just for clarification. So that when the gssoc team Reviews your profile they shoud not question you!

ayush-848 commented 3 months ago

Yes @ayush-848 I'm asking the admin only, as I have been instructed if the page is not created by the Contributor and has only Enhancement then it should be level 1 or level 2,

The difference between the PR #196 and yours is what made me curious.

If you have re-created the entire FAQ page or did any functionality additions (complex one) then the level 3 label is understandable!

I'm just asking as the previous PR has level 2 but as compare to the changes this PR has level 3. So Just for clarification. So that when the gssoc team Reviews your profile they shoud not question you!

Yeah compared to #196 this was not that much of a change