search

AbigaelWairimu / Developer-Learning-Paths

https://developer-learning-paths.vercel.app
MIT License
5 stars 3 forks source link

Add Fallback for SVG Icon #6

Open AbigaelWairimu opened 1 month ago

AbigaelWairimu commented 1 month ago

Our current website uses an SVG icon as the favicon. While SVG is a modern and scalable format, some older browsers do not support SVG favicons. To ensure our favicon is displayed correctly across all browsers, we need to provide a fallback PNG or ICO favicon.

Tasks:

  1. Create Fallback Icon: Convert the SVG favicon to a PNG or ICO format. This can be done using an online converter or a graphic design tool.

  2. Add Fallback to HTML: Update the HTML to include the fallback favicon. This typically involves adding a link element with rel="icon" and the href pointing to the fallback icon. This link should be placed after the SVG favicon link, so that browsers that support SVG favicons will still use the SVG version.

Acceptance Criteria:

  1. A fallback PNG or ICO favicon has been created and added to the project.

  2. The HTML has been updated to include the fallback favicon.

  3. The favicon displays correctly in older browsers that do not support SVG favicons.

vvu11 commented 1 month ago

Hi @AbigaelWairimu I'd like to take on this issue if you would assign it to me! :)

AbigaelWairimu commented 1 month ago

Hi. yeah of course.

On Tue, May 14, 2024 at 7:45 PM vvu11 @.***> wrote:

Hi @AbigaelWairimu https://github.com/AbigaelWairimu I'd like to take on this issue if you would assign it to me! :)

— Reply to this email directly, view it on GitHub https://github.com/AbigaelWairimu/Developer-Learning-Paths/issues/6#issuecomment-2110685010, or unsubscribe https://github.com/notifications/unsubscribe-auth/BABH42VVR5R7FU3WAJJBNELZCI5S5AVCNFSM6AAAAABHVTSCTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJQGY4DKMBRGA . You are receiving this because you were mentioned.Message ID: @.***>

vvu11 commented 1 month ago

i just created a new pull request - please let me know if there are any conflicts or if its all good to go

AbigaelWairimu commented 1 month ago

Looks good. Thank you so much

On Wed, May 15, 2024 at 12:04 AM vvu11 @.***> wrote:

i just created a new pull request - please let me know if there are any conflicts or if its all good to go

— Reply to this email directly, view it on GitHub https://github.com/AbigaelWairimu/Developer-Learning-Paths/issues/6#issuecomment-2111139866, or unsubscribe https://github.com/notifications/unsubscribe-auth/BABH42VY4O2FTOB6OFBD7R3ZCJ37TAVCNFSM6AAAAABHVTSCTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJRGEZTSOBWGY . You are receiving this because you were assigned.Message ID: @.***>