AbiosGaming / desktop-stream-viewer

View multiple streams on your desktop!
7 stars 1 forks source link

Change to responsive settings_dialog #170

Closed svenanderzen closed 7 years ago

svenanderzen commented 7 years ago

Description

Previously, the settings dialog was not responsive (at least not on Linux, haven't tested on any other platform, but doubt it's any difference). This PR makes the dialog responsive as well as adds some other clarifications to the UI code and naming.

Have tested it so that it works, but please double check that I haven't missed anything!

Important files to review

main.py constants.py ui/settings_dialog.ui

Before

Default size

old_default

Enlarged size

old_large

Minimized size

old_small

After

Default size

new_default

Enlarged size

new_large

Minimized size

new_small

See also

svenanderzen commented 7 years ago

LOL, I'm an idiot... @MDinler already have a branch (#168) open with this... 🤦‍♂️ Sorry!

ghost commented 7 years ago

@svenanderzen I merged #168 Before Reading this... woops

svenanderzen commented 7 years ago

No problems @MDinler , it's totally my fault so I only have my self to blame :)

However since they're more or less the same is it okey if I merge this over master? The changes that I think motivates this are:

And last but not least; PR #171 builds upon this branch.

Again, sorry ❤️