Closed svenanderzen closed 7 years ago
LOL, I'm an idiot... @MDinler already have a branch (#168) open with this... 🤦♂️ Sorry!
@svenanderzen I merged #168 Before Reading this... woops
No problems @MDinler , it's totally my fault so I only have my self to blame :)
However since they're more or less the same is it okey if I merge this over master? The changes that I think motivates this are:
.ui
file are changed to more appropriate names in my opinion.horizontal layout
at the bottom of the file.dialog.ui
to a more appropriate settings_dialog.ui
and this filepath is now determined by a variable in constants.py
.And last but not least; PR #171 builds upon this branch.
Again, sorry ❤️
Description
Previously, the settings dialog was not responsive (at least not on Linux, haven't tested on any other platform, but doubt it's any difference). This PR makes the dialog responsive as well as adds some other clarifications to the UI code and naming.
Have tested it so that it works, but please double check that I haven't missed anything!
Important files to review
main.py
constants.py
ui/settings_dialog.ui
Before
Default size
Enlarged size
Minimized size
After
Default size
Enlarged size
Minimized size
See also