search

AbiosGaming / desktop-stream-viewer

View multiple streams on your desktop!
7 stars 1 forks source link

Videoframegrid #80

Closed svenanderzen closed 7 years ago

svenanderzen commented 7 years ago

Description

This PR adds a new class VideoFrameGrid that will be the main parent element for all of our LiveVideoFrames. The class handles the StreamCoordinates (now renamed to VideoFrameCoordinates) as well as the updating of these. The UI file have received a container that's just a VBoxLayout (since there has to exist a root layout element in the UI file) where the VideoFrameGrid is added to.

Important files to review

main.py videoframegrid.py

svenanderzen commented 7 years ago

Place the move_frame function inside VideoFrameGrid? Won't we still have to pass down self from the application to VideoFrameGrid anyway then?

Or are you referring to something else?

svenanderzen commented 7 years ago

I'll just have to merge with master first though 🔨

svenanderzen commented 7 years ago

All ready to merge. Please review @kaszim or @mictab

svenanderzen commented 7 years ago

Passively aggressive ping @kaszim @mictab

kaszim commented 7 years ago

Looks good, nothing to add 👍