search

AbiosGaming / desktop-stream-viewer

View multiple streams on your desktop!
7 stars 1 forks source link

Parent fix #97

Closed kaszim closed 7 years ago

kaszim commented 7 years ago

Description

This fixes a couple of issues that appeared because video frames were not parented. Firstly they will now properly be css:ed. Also this improved performance greatly.

While at it I tested some vlc flags, and found that opengl performed better than directx, so I changed that too.

Important files to review

main.py videoframegrid.py videoframes.py

kaszim commented 7 years ago

93 Will have a easier time skinning now.

kaszim commented 7 years ago

@svenanderzen Could you try creating a vlc_instance in the container instead? For me I reduce cpu usage by 10 % units. Feels like I am seeing things that are not real though 😨

kaszim commented 7 years ago

@svenanderzen Can you review the changes? As alot of ui functioanlity depends on the fixes introduced here. Oh and why is travis failing my builds? I don't see vlc imported in main 😨 @mictab help pls

mictab commented 7 years ago

@kaszim It's imported here 😊 https://github.com/kaszim/desktop-stream-viewer/blob/4b82963a2d713964f1aceb28810d0991465efdf7/main.py#L237

svenanderzen commented 7 years ago

LGTM