search

Abjad / abjad

Abjad is a Python API for building LilyPond files. Use Abjad to make PDFs of music notation.
https://abjad.github.io
GNU General Public License v3.0
239 stars 39 forks source link

Add type hint to from_pitch classmethod #1476

Closed jgarte closed 2 years ago

trevorbaca commented 2 years ago

Hi @jgarte looks like mypy fails when GitHub actions runs. Did you run mypy before you opened the PR?

jgarte commented 2 years ago

Hi @jgarte looks like mypy fails when GitHub actions runs. Did you run mypy before you opened the PR?

No, I didn't.

Going to try again after I think about/debug why mypy doesn't like that.

trevorbaca commented 2 years ago

The mypy developers seem to change things fairly often; make sure to update mypy on your machine (pip install --upgrade mypy); that might reveal a difference between the version of mypy on your laptop versus GitHub.

jgarte commented 2 years ago

I'll reopen this again soon once I get more time. Thanks for the tips.