search

Ableton / LinkKit

iOS SDK for Ableton Link, a new technology that synchronizes musical beat, tempo, and phase across multiple applications running on one or more devices.
http://ableton.github.io/linkkit
Other
147 stars 10 forks source link

stdbool.h added in ABLLink.h #41

Closed ghost closed 6 years ago

ghost commented 6 years ago

This implementation fix bug <Unknown type name 'bool'> in ABLLink.h that appears on Xcode 9 with Swift 4

cdi-ableton commented 6 years ago

Thanks for the fix! To be able to merge your PR I need a signed Contributor License Agreement. You find all the information here: http://ableton.github.io/cla/

ghost commented 6 years ago

http://ableton.github.io/cla/ I can't reach this page

cdi-ableton commented 6 years ago

Hmm. That's unfortunate. The link should be correct. Could you check if https://ableton.github.io/link/ is working for you? If yes, please try https://ableton.github.io/cla/ again.

ghost commented 6 years ago

yea, now I can download the file. I will send it filled soon. Thank you

ghost commented 6 years ago

I have just send the cla to cla@ableton.com

ghost commented 6 years ago

Have you received my CLA?

cdi-ableton commented 6 years ago

Thanks for following up and sorry for the delay! Unfortunately, I haven't received it yet because – as I just found out – it got stuck somewhere in the process chain.

ghost commented 6 years ago

No problem! If you need I can re send it one more time

cdi-ableton commented 6 years ago

Finally, I've received the CLA. Before I merge I'd like to ask you to squash the two commits. Thanks!

kennmichael commented 3 years ago

I'm getting this error again when using the xcframework. - Unknown type name 'bool'

Trying to compile LinkKit 3.1.5 with Xcode 12.4 in a pure SwiftUI multiplatform app. In iOS, importing ABLLink.h in a Bridging Header. Also tried importing libc++.

ABLLink.h only has an import statement for stdint and not stdbool.

This also happens in a completely clean project. LinkHut compiles just fine, but it's not a SwiftUI app/project.

On Sat, Nov 18, 2017 at 9:35 AM Domenico Merone @.***> wrote:

Closed #41 https://github.com/Ableton/LinkKit/pull/41.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Ableton/LinkKit/pull/41#event-1348471129, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyRpxIOKHJzAdq_iPucwHgPFBMh6D7Kks5s3xV7gaJpZM4Ptq4X .

fgo-ableton commented 3 years ago

It seems I accidentally removed the include in a527aa099b2e9e9549616d4533e881bc43f7d462. Could you please check if this build works for you with SwiftUI?

kennmichael commented 3 years ago

This build works! Thanks for the super quick response!

On Fri, Mar 26, 2021 at 7:44 AM fgo @.***> wrote:

It seems I accidentally removed the include in a527aa0 https://github.com/Ableton/LinkKit/commit/a527aa099b2e9e9549616d4533e881bc43f7d462. Could you please check if this build https://github.com/Ableton/LinkKit/files/6212465/LinkKit.zip works for you with SwiftUI?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Ableton/LinkKit/pull/41#issuecomment-808274973, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6JDJZYQZACC67VOTTXDILTFSMU5ANCNFSM4D5WVYLQ .

fgo-ableton commented 3 years ago

Cool. I published a new release with the fix.