search

Ableton / LinkKit

iOS SDK for Ableton Link, a new technology that synchronizes musical beat, tempo, and phase across multiple applications running on one or more devices.
http://ableton.github.io/linkkit
Other
147 stars 10 forks source link

Fix SettingsViewController instance method return type for Swift #46

Closed cemolcay closed 6 years ago

cemolcay commented 6 years ago

Change factory method return type to instancetype. Using instancetype return type instead of id is the cocoa way for creating init methods. It automatically returns the type of initializing class. So, it is more Swift friendly.

fgo-ableton commented 6 years ago

Thanks for the PR. The suggested change makes sense! Unfortunately it also requires some under the hood changes. I'll release an update soonish.

fgo-ableton commented 6 years ago

Here is a new build: https://github.com/Ableton/LinkKit/releases/tag/LinkKit-2.1.4 https://github.com/Ableton/LinkKit/commit/ea61ee712f42c714a6f74cc7b69476a74db94a4a Thanks again!