Ableton / aqt-stylesheets

Apply CSS style sheets to QML applications
Other
215 stars 39 forks source link

Search path for urls #14

Closed gck-ableton closed 9 years ago

gck-ableton commented 9 years ago

The idea is to lookup local resources like fonts or icons in CSS files from a search path. By default the search path is set to the importPathList() from the QQmlEngine. In that way a font or icon can live near a QML file and being referenced relative to the QML file's folder, even if the CSS file is coming from somewhere else.

The previous strategy to lookup resources relative to a CSS's file location is kept as primary strategy though. I.e. the CSS's location is the first item in the search path.

@sbs-ableton @rof-ableton @dir-ableton

gck-ableton commented 9 years ago

@sbs-ableton @rof-ableton @dir-ableton Maybe you can give it a quick review?

sbs-ableton commented 9 years ago

It LGTM - feel free to ignore the nitpick :neckbeard:

gck-ableton commented 9 years ago

@dir-ableton I've change it as discussed offline. Path's starting with "./" or "../" are resolved only relative to the base url. Relative paths without leading "." are resolved relative to baseurl and searched for in the searchPath. Probably you can take another look, if this matches your idea?

gck-ableton commented 9 years ago

@dir-ableton The more css-like approach is now in place. Maybe you want give it a last try?