Ableton / aqt-stylesheets

Apply CSS style sheets to QML applications
Other
214 stars 39 forks source link

Path based property map building #31

Closed mli-ableton closed 8 years ago

mli-ableton commented 8 years ago

This PR builds the property maps by walking up the path hierarchy instead of the Item view/object hierarchy. This is a prerequisite for sharing StyleSets between StyleSetAttached instances. Along the way this fixes some bugs that have been revealed when writing regression tests.

The actual change in commit "Inherit properties by walking the path instead of the view object hierarchy" degrades performance (details in commit message). We expect this to be a non-issue anymore as soon as StyleSets are shared. For that reason, please don't merge until the concept of shared StyleSets has been proven with a following PR that we will notify you about once it is reviewable.

@gck-ableton: please review! Thanks! @mak-ableton: FYI