Ableton / aqt-stylesheets

Apply CSS style sheets to QML applications
Other
215 stars 39 forks source link

Make qmldir static #52

Closed nil-ableton closed 7 years ago

nil-ableton commented 7 years ago

We remove the dynamic/rewritten qmldirs to make integration a little easier.

nre-ableton commented 7 years ago

Looks like AppVeyor failed because Qt 5.3's qmltestrunner.exe lacks the -plugin option. Fortunately, AppVeyor has a few different Qt flavors to choose from:

https://www.appveyor.com/docs/installed-software/#qt

Looking at the README of this repo, it seems that this was intentional because we want to support a minimum version of 5.3. @ala-ableton is it possible to bump this version? IMHO it makes the most sense to set 5.6.1 as the minimum, since that would mirror what we use internally (and is not bleeding edge), but I can see that might also cause problems for some users. What do you think?

nil-ableton commented 7 years ago

I would fix the CI so that it works for 5.3 as well. It's easy enough to add DYLD_LIBRARY_PATH and PATH environment variables there, which is what ultimately users of those versions would have to do. I can adapt the README to indicate that.

nre-ableton commented 7 years ago

@nil-ableton Ok, sounds like a plan.

ala-ableton commented 7 years ago

@nil-ableton: setting DYLD_LIBRARY_PATH and PATH don't replace the -P/-plugins options, so I don't see how you want to make it work with Qt 5.3...

nil-ableton commented 7 years ago

Yes indeed it does not work, that's what I was seeing now. I thought this worked because in the past we were adding the build output directory to the PATH and DYLD_LIBRARY_PATH. In retrospect this must have been for libraries we load dynamically?

This was in some ci-hooks, and I did check before hand..

nil-ableton commented 7 years ago

http://doc.qt.io/qt-5/qqmlengine.html#addPluginPath does confirm this:

By default, the list contains only ., i.e. the engine searches in the directory of the qmldir file itself.

I'll use an alternative method (copying)

ala-ableton commented 7 years ago

@nil-ableton: why not simply use a more recent version of Qt?

nil-ableton commented 7 years ago

Because my default standpoint is to not change a component to give less to our users than what they already have if I can avoid it.

If I can make the CI work on 5.3 then we prove that 5.3 is usable, and the component stays the same.

ala-ableton commented 7 years ago

Makes sense :+1:

nil-ableton commented 7 years ago

All green! My solution was to add an install step to bundle qmldir + plugin inside the build directory. I think it's nicer anyway like that for users, as they can then copy that bundled qml directory into their global qt installation or in their application

nil-ableton commented 7 years ago

This rewritten version should be pretty good. Let me know if you have anything more and feel free to merge once this is once again green. Thanks

ala-ableton commented 7 years ago

LGTM :+1:

ala-ableton commented 7 years ago

@gck-ableton: please review and merge if LGTY.

gck-ableton commented 7 years ago

👍 Thanks for the effort!