Closed toh-ableton closed 6 years ago
In Gregor's absence, would you be able to review this, @ala-ableton? Thanks!
@toh-ableton could you please make the PR title, PR description and commit message agree?
I've updated the description; and I'll update the commit message when I squash the commits.
@toh-ableton thanks for updating the PR description. However, I really would like to see the final commit message, which should explain why we are updating cpp-peglib
and why to that commit in particular.
I'm a bit confused about what you want to me to do now. We're updating to beaa0346ca because it's the lastest master, and we need it because we need it to build a PR on one of our private repos that uses clang 5.
@ala-ableton ptal
LGTM :+1:
👍 nachträglich.
https://github.com/yhirose/cpp-peglib/blob/beaa0346ca/peglib.h
RFC @gck-ableton FYI @csd-ableton