Ableton / aqt-stylesheets

Apply CSS style sheets to QML applications
Other
214 stars 39 forks source link

Update cpp-peglib to beaa0346ca76e52e32a23fd04eb7605cb7313059 #61

Closed toh-ableton closed 6 years ago

toh-ableton commented 6 years ago

https://github.com/yhirose/cpp-peglib/blob/beaa0346ca/peglib.h

RFC @gck-ableton FYI @csd-ableton

toh-ableton commented 6 years ago

In Gregor's absence, would you be able to review this, @ala-ableton? Thanks!

ala-ableton commented 6 years ago

@toh-ableton could you please make the PR title, PR description and commit message agree?

toh-ableton commented 6 years ago

I've updated the description; and I'll update the commit message when I squash the commits.

ala-ableton commented 6 years ago

@toh-ableton thanks for updating the PR description. However, I really would like to see the final commit message, which should explain why we are updating cpp-peglib and why to that commit in particular.

toh-ableton commented 6 years ago

I'm a bit confused about what you want to me to do now. We're updating to beaa0346ca because it's the lastest master, and we need it because we need it to build a PR on one of our private repos that uses clang 5.

toh-ableton commented 6 years ago

@ala-ableton ptal

ala-ableton commented 6 years ago

LGTM :+1:

gck-ableton commented 6 years ago

👍 nachträglich.