search

Ableton / link

Ableton Link
Other
1.09k stars 149 forks source link

Add "/wd4503" only if on MSVC compiler #77

Closed Xartrick closed 4 years ago

Xartrick commented 4 years ago

This issue is also related to MinGW (#69) but not related to htonll and ntohll, so I guess it belong to another PR.

https://github.com/Ableton/link/blob/master/AbletonLinkConfig.cmake#L36

set_property(TARGET Ableton::Link APPEND PROPERTY
  INTERFACE_COMPILE_OPTIONS
  "/wd4503" # 'Identifier': decorated name length exceeded, name was truncated
)

/wd4503 is recognized as a directory by GCC and fails as its only recognized by MSVC compiler :

error: /wd4503: No such file or directory
fgo-ableton commented 4 years ago

Thanks a lot! It turns out this was not needed at all anymore. I removed the entire section on the latest master.

Xartrick commented 4 years ago

Thank you, I'm closing this PR.