search

Ableton / maxdevtools

MIT License
271 stars 14 forks source link

Add amxddiff #1

Closed MattijsKneppers closed 10 months ago

MattijsKneppers commented 10 months ago

Adds the amxddiff tool.

MattijsKneppers commented 10 months ago

@ama-ableton thanks a lot for your feedback! Everything should be implemented.

MattijsKneppers commented 10 months ago

Thanks for all the great feedback @jby-ableton! I have implemented all your feedback as far as I can see.

I only diverged for the suggestion of using snake_case for now; everything is still consistently camelCase at the moment, but I'm not against changing this in one go later seeing that snake_case is apparently preferred for Python according to PEP8.

MattijsKneppers commented 10 months ago

@hdj-ableton I had no idea that unittest already supported diffing when comparing strings for equality, this simplified the test code a lot, thanks for bringing that up. Thanks for all the suggestions! They are all applied except the one about encryption, see my comment.