GitHub Action to run the tests on every pull request

Ableton / maxdevtools

MIT License

271 stars 14 forks source link

GitHub Action to run the tests on every pull request #17

Closed cclauss closed 4 months ago

cclauss commented 8 months ago

Test output: https://github.com/cclauss/maxdevtools/actions

MattijsKneppers commented 8 months ago

Thank you for this PR @cclauss, which immediately points out a flaw in the tests that was introduced some time ago (now fixed with #19). We're looking into this PR and get back to you.

cclauss commented 8 months ago

Rebased to the main branch just to prove that #19 fixed the tests.

cclauss commented 6 months ago

If you are going to run prbase then you should probably enable contributors to rebase their PRs on the current branch.

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-rebasing-for-pull-requests

MattijsKneppers commented 6 months ago

@cclauss thanks for all the updates. I requested for rebasing to be enabled and will let you know when that has happened.

In the mean time, I wonder if you have noticed the requirement in the contributing guidelines that Ableton has received a CLA from any contributors. Would you be able to submit one for us?

cclauss commented 6 months ago

Done.

cclauss commented 6 months ago

Do these three suggestions cover it?

MattijsKneppers commented 6 months ago

@cclauss they do, thank you!

MattijsKneppers commented 4 months ago

Hi @cclauss, sorry for the long wait. We needed a bit more discussion, but it's all approved now. It would be great if you can rebase one last time and then I can merge.

cclauss commented 4 months ago

Rebased.