search

Ableton / maxdevtools

MIT License
271 stars 14 forks source link

Tweak CI: remove on push for PRs and add names to CI steps #37

Closed MattijsKneppers closed 4 months ago

MattijsKneppers commented 4 months ago

We originally included push to make sure PRs get tested when new commits are added or existing commits are changed.

However, it appears that for an active PR, every push already causes a synchronize activity type for the pull_request_target event, which triggers the workflow. See the pull_request_target documentation.

So the push event is no longer needed for PRs. Instead, we set it to trigger only for the case when something was pushed directly to the main branch as documented here.

Also adds names to CI steps like in GitHub's examples.

jamesb93 commented 4 months ago

Makes sense!

MattijsKneppers commented 4 months ago

A good point from @ala-ableton: when removing the push event, the tests will no longer run when something is pushed directly to main. To counter that I re-added push but set it to only trigger for the main branch as documented here.