search

AbodeSaafan / pickup

Project Pickup is the SOTI intern project for 2017/18. The idea is an app that helps you create and find local pick up basketball games.
GNU General Public License v3.0
1 stars 1 forks source link

Create New Game - Navigation specific changes #139

Closed GitGeminiano closed 6 years ago

GitGeminiano commented 6 years ago

Notice that the new fab for creating new games is not part of the side menu. For this reason, some changes were introduced for the navigating between fragments (Do not assume we will always click on a menu item to move in between fragments), but there are still a few changes to be made. For instance, the map item is still selected when we move to the new Create Game fragment.

Also, consider refactoring the visibility checks so that visibility is decided on onCreate() instead of doing it when replacing fragments or when a back press happens, since this will make the code more scalable and reduce the amount of places where we check whether we should enable the visibility of certain objects.

GitGeminiano commented 6 years ago

@AbodeSaafan This is how I think we should handle fragments.

AbodeSaafan commented 6 years ago

Looks good to me, passing review but please present findings/ new flow in next meeting