search

AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
39 stars 34 forks source link

1.12.2 #194

Closed Wyn-Price closed 6 years ago

Wyn-Price commented 6 years ago

It would be a good idea to also create a new branch for 1.12.2. Also if i could have access to this repo so I can make changes to the code without having to create a PR every time

AbrarSyed commented 6 years ago

I totally agree with you. After this initial PR to put your stuff in, il give you contributor access so you can manage it as you see fit.

Now.. I have some changes I would like to request.

  1. Keep the old gitignore. I honestly think the old one is superior to the one you replaced it with. Maybe add the few lines to ignore the hsperrid and bluej files.
  2. Keep the License file (assuming ofcrouse its still LGPL) or replace with a different appropriate license file.
  3. Keep most of the old readme. Sure change the description up top, but the stuff like links to curseforge and forum posts as well as building instructions should stay. Good info on readmes.
  4. Keep the dpeloyment part of the build.gradle. basically the entire uploadArchives part and related sections. That's important for the jenkins stuff.

Also see my other in-line comments

Wyn-Price commented 6 years ago

I had to change the .gitignore as it spammed an immense amount of eclipse files into git. I can work out what to change and add the lines

Wyn-Price commented 6 years ago

Ok Im pretty much done with this for now. Unless theres somthing else i could add or there bugs that need squashing I think theres not much more I can do with this. If you want to merge the branches you can, or you can keep it how it is i dont mind