AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
40 stars 35 forks source link

Gate Block rendering issues? (along with other things) #197

Closed Akitori closed 7 years ago

Akitori commented 7 years ago

2017-11-19_12 49 38 So I'm not certain entirely how the gateblock works, it's supposed to render a entire row of blocks, right? Well, mine currently isn't, shows some as vanished, others as not.

Latest release, (just released even) with forge 2509.

Also found a bug involving 2 items, one of which may not be a bug and a feature while the other certainly is a bug.

Feature?: Hidden daylight sensors aren't able to be inverted like the vanilla counterparts.

Bug: Secret Trapped Chest gives no redstone output at all.

Wyn-Price commented 7 years ago

what is the secret gate disguesed as. Also the secret daylight sensors are able to invert, but ill make sure now. Secret Trapped chests give +1 redstone output for how many people are using them. I havnt added comparator output yet but ill work on that

Akitori commented 7 years ago

Secret gate was grass block, but bug occurs on all blocks tested (vanilla and modded)

Wyn-Price commented 7 years ago

also regarding the gate, can you try putting the gate a somthing that dosnt have a full bounding box (like a torch) and activate it. then see if the non rendered blocks have the same bounding box

Wyn-Price commented 7 years ago

Ok i figured out what causes the non rendered blocks. Its when you stand in the way of the gate while activating it. Fixing now

Wyn-Price commented 7 years ago

also one last thing, could you check the logs and see if theres any errors

Akitori commented 7 years ago

Tested with gate block, gate block does not take bounding block of torch, its all cubed. Also for any errors in logs, none are popping up on console server side at least.

Akitori commented 7 years ago

Concerning thing to note, the gateblock parts (the long invisible blocks) don't disappear when the gate block is broken..is that intentional?

Wyn-Price commented 7 years ago

no its not. Ill fix that now

Wyn-Price commented 7 years ago

also can you look at the client logs, i think it might be an issue there

Akitori commented 7 years ago

Found something interesting.

[13:24:38] [main/FATAL]: Error executing task java.util.concurrent.ExecutionException: java.lang.NullPointerException at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_25] at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_25] at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1086) [bib.class:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397) [bib.class:?] at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_25] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_25] at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] Caused by: java.lang.NullPointerException at net.minecraft.client.network.NetHandlerPlayClient.func_147234_a(NetHandlerPlayClient.java:774) ~[brz.class:?] at net.minecraft.network.play.server.SPacketBlockChange.func_148833_a(SourceFile:40) ~[ij.class:?] at net.minecraft.network.play.server.SPacketBlockChange.func_148833_a(SourceFile:13) ~[ij.class:?] at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[hv$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_25] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_25] at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?] ... 9 more [13:24:38] [main/FATAL]: Error executing task java.util.concurrent.ExecutionException: java.lang.NullPointerException at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_25] at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_25] at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1086) [bib.class:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:397) [bib.class:?] at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_25] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_25] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_25] at java.lang.reflect.Method.invoke(Method.java:483) ~[?:1.8.0_25] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] Caused by: java.lang.NullPointerException at net.minecraft.client.network.NetHandlerPlayClient.func_147273_a(NetHandlerPlayClient.java:1214) ~[brz.class:?] at net.minecraft.network.play.server.SPacketUpdateTileEntity.func_148833_a(SourceFile:54) ~[ih.class:?] at net.minecraft.network.play.server.SPacketUpdateTileEntity.func_148833_a(SourceFile:11) ~[ih.class:?] at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[hv$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_25] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_25] at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?] ... 9 more

This was in the client logs...Says something about packet updates and tile entities. Might be the thing you're looking for?

Wyn-Price commented 7 years ago

how often did you get this issue. Was it every time or did it not happen that often

Akitori commented 7 years ago

Happened twice in the log, I'm not sure of specifics, guessing when i used the gate blocks.

Wyn-Price commented 7 years ago

was it every time you used the gate blocks or randomly

Akitori commented 7 years ago

I would say randomly.

Wyn-Price commented 7 years ago

ok ive managed to replicate it multiple times. I found out what causes it but i cant figure out why

Wyn-Price commented 7 years ago

Ok i think ive come up with a solution to the first issue and have fixed the block breaking issue Regarding the light detector: light-gif

Akitori commented 7 years ago

that's cool!

Wyn-Price commented 7 years ago

ok i also fixed the trapped chest issue comparator-gif

Wyn-Price commented 7 years ago

@Akitori ok releasing a new version now. Should be uploaded soon