search

AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
39 stars 35 forks source link

Low TPs, Random blocks vanishing and more #205

Closed Akitori closed 6 years ago

Akitori commented 6 years ago

https://youtu.be/LLATmAum0Tw

Send help. Forge is 2555, secret rooms is latest

Wyn-Price commented 6 years ago

Do you close the server for the bugs to happen or just leave and rejoin. I'll do some testing and I'll look into it, however I do have school exams this week so i won't be able to fix them all straight away

Wyn-Price commented 6 years ago

Ill look into it now tho. I have time now

Wyn-Price commented 6 years ago

Are there anything in the fml-latest-client.log or fml-latest-server.log

Wyn-Price commented 6 years ago

seeing as I cant replicate this, is there any chance I would be able to join your server and do bug testing. You'd have to turn online-mode to false in the server-properties

Akitori commented 6 years ago

Currently the bug happens upon clients rejoining and connecting mainly. Even something as simple as walking out of the chunks.

Wyn-Price commented 6 years ago

It sounds like an issue with the NBT saving of tile entities. If I could join your server later it would help as it can be hard to replicate these things

Akitori commented 6 years ago

here's something interesting.

2017-12-02_15 46 28

The first red line (after the error) is from a invisible secret redstone. The second is from a visible secret redstone shortly after its placed on grass. Think you're right with the nbt thing.

Wyn-Price commented 6 years ago

Ah yes that was a big help. Im think i know why its happening so ill send you the .jar soon. As for the redstone, im not sure whats causing it, but ill look further

Wyn-Price commented 6 years ago

Ok ive fixed the issue with the vanishing blocks. The problem was that the packet being sent wasnt fast enough. Ive it now so there is no packet being sent so it works

Wyn-Price commented 6 years ago

and for the redstone, I might just rewrite the logic for it, so it can go upwards as well

Wyn-Price commented 6 years ago

If your avaliable, I have a .jar that you could test out. Ive rewritten the redstone to be able to go vertical, but it may be buggy

Akitori commented 6 years ago

Alright I'm available to test.

Wyn-Price commented 6 years ago

secretroomsmod-5.1.9.zip The wire should be able to go upwards and things, however i didnt change that much of the code, so the lag may still be there

Akitori commented 6 years ago

right, some bugs immediately. (secret redstone isn't able to be picked up via hand anymore, only pickaxe it seems?) some circuits using secret redstone needed to be updated but nothing major.

Wyn-Price commented 6 years ago

Yeh the logic for the circuits has changed. Is there tps issues still ?

Akitori commented 6 years ago

Not as far as i can see.

Wyn-Price commented 6 years ago

I'll send you the updated version in a minute then see if you can find any issues with it

Wyn-Price commented 6 years ago

secretroomsmod-5.1.9.zip

Akitori commented 6 years ago

Everything is working just fine now! Thanks!