AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
40 stars 35 forks source link

[1.12.2] SecretRooms Mod loading Client Side Code on Server side in v5.5.0 #236

Closed Morpheus1101 closed 6 years ago

Morpheus1101 commented 6 years ago

Optifine?: Hell No :D

Forge *.2625 SR v5.5.0

Log @ https://gist.github.com/Morpheus1101/6fd203b78911a27592d6a78fe14c58c4

Wyn-Price commented 6 years ago

Oops I forget to check this. Fix coming out in less than an hour

Morpheus1101 commented 6 years ago

v5.5.1 still has this issue

Wyn-Price commented 6 years ago

@Morpheus1101 can you send the fml-client-latest.log

Morpheus1101 commented 6 years ago

fml-server-latest.log

Havent attempted to load it on client side yet since the server dosent load.

I could load client with the 5.5.1 vers if you need it.

Wyn-Price commented 6 years ago

Is that on the server? The coremods being loaded for some reason.

Wyn-Price commented 6 years ago

I'll add more checks now

Morpheus1101 commented 6 years ago

Yes it is on server

Wyn-Price commented 6 years ago

Are you able to test this? It should all be working now.

felesmortis commented 6 years ago

@Wyn-Price That works for me.

Wyn-Price commented 6 years ago

@felesmortis ok, I'll mark this as fixed and release a new version on curseforge

Morpheus1101 commented 6 years ago

This is occurring again in 5.5.3 with same class but different crash file

https://gist.github.com/Morpheus1101/e1a18cc7e2bc8c05630c01531274765b

Wyn-Price commented 6 years ago

Oof sorry about that

Wyn-Price commented 6 years ago

@Morpheus1101 Does this fix it?

Morpheus1101 commented 6 years ago

Yes it does

Majora320 commented 6 years ago

@Wyn-Price Still happening for me on 5.5.4 Edit: Crash report: https://ptpb.pw/pVLx

Wyn-Price commented 6 years ago

@Majora320 Ok thats weird. Working on a fix now

Wyn-Price commented 6 years ago

@Majora320 ok does this version work?

Majora320 commented 6 years ago

@Wyn-Price Yep, that seems to fix it. Thanks!

Majora320 commented 6 years ago

@Wyn-Price I'm now getting a new error when trying to join the server (client side): https://ptpb.pw/-jtb

Wyn-Price commented 6 years ago

@Majora320 sorry for taking so long, I didnt see this. Does this version sort out the issue?

Majora320 commented 6 years ago

@Wyn-Price Yep, that seems to work. Thanks!