AbrarSyed / SecretRoomsMod-forge

The official SecretRoomsMod repo
GNU Lesser General Public License v3.0
39 stars 34 forks source link

[1.12.2] [Request] Light issues, Config for MD and HYWLA Integration #252

Open Skaphegor opened 6 years ago

Skaphegor commented 6 years ago

I noticed that SRM adds compat to MD but I do not want to have this integration because it causes light issues. The SRM does not add any config to prevent compat. Could this be added?

Wyn-Price commented 6 years ago

What are the light issues, I might be able to fix those as well

Skaphegor commented 6 years ago

Yeah I decided to turn off all animation of doors because not all doors in my modpack have this implemented. However I made you screenshots of the light issue. First with and second without Optifine but it is the same result.

This happens after I added MD. 2018-06-09_21 52 21 2018-06-09_22 01 42

There is also another issue that occured before. I do not know if this is already known. This happens before I added MD. 2018-06-09_21 52 29 2018-06-09_22 01 52

There also a third issue. As you can see the door imitates black granite but in HWYLA it is declared as red granite. That might be caused by meta data that is not used for gathering the block variant.

Wyn-Price commented 6 years ago

I'll look into the hwyla stuff, but the inside of the door is always going to be dark, due to the way the light engine works

Wyn-Price commented 6 years ago

But the outside of the door shouldn't be like that no. It seems to be darker than the surrounding blocks. is it the same block as the surrounding?

Skaphegor commented 6 years ago

yeah. it is all black granite.

And I thought the inner was too dark because you cannot see which block it is. But this might not be an issue. Secret Doors won't be opn for long time.

Wyn-Price commented 6 years ago

Is the block texture correct?

Skaphegor commented 6 years ago

The block underneath the door? yes.

Wyn-Price commented 6 years ago

Can you take the screenshots again but with better light

Wyn-Price commented 6 years ago

Like light it up with torches or something

Skaphegor commented 6 years ago

It seems that it only happen if a block is placed above the door.

2018-06-09_22 55 03 2018-06-09_22 55 10

diademos commented 5 years ago

Hey, i have the same. any updates on that? Regards Diademos

diademos commented 5 years ago

2018-08-19_11 52 12 This is how it looks like on the the Server

Wyn-Price commented 5 years ago

Im looking into it