AbreezaSaleem / react-voice-recorder-player

Voice Recorder Component for React
MIT License
23 stars 5 forks source link

Incorrect file extension when downloading audio file using react-voice-recorder-player (audio.wav) #3

Closed faizaniqbalLC closed 1 year ago

faizaniqbalLC commented 1 year ago

I am using react-voice-recorder-player for audio recording and downloading, but I am experiencing an issue where the downloaded audio file is being saved with audio.wav extension instead of the desired .mp3 extension. This makes it difficult for me to work with the file as I need it to be in the .mp3 format.

image

I have updated code inside \src\components\controllers\index.tsx. You can check, It's working fine with audio.mp3.

AbreezaSaleem commented 1 year ago

You'll need to test the complete functionality of the package before we can merge it.

You will need to test it across all main browsers:

On both desktop and mobile devices. And if you have access to Mac and Windows laptops, then test on both of them as well.

Here is what you'll need to test:

Afaik, the playback functionality does not work properly on Safari unless you set the Audio File extension to wav. This is why it's been explicitly defined in the codebase. Please state your reason for wanting to set the extension to mp3. If its only because it is convenient to play mp3 files on windows then I'm afraid we can't merge this PR.

AbreezaSaleem commented 1 year ago

I understand this. But please explain why you want this implemented? Why do you need mp3 format?

AbreezaSaleem commented 1 year ago

What issue are you facing? From what I gather from your initial message, you would prefer the format to be in mp3 instead of wav. That is not an issue, it's a preference. Please clarify the exact issue you're facing and then we can proceed with making any required changes. Thanks.