add mark-as-done

[tharvik]

Checklist

• [x] I read and understood the Contributing Guidelines.
• [x] This is not a duplicate of an existing merge request.
• [x] This is not a translation update.
• [x] I believe this falls into the scope of the project and should be part of the built-in functionality.
• [x] My code follows the code style of this project.
• [x] All new and existing tests pass.

Changes

• update ShoppingListAdapter.changeItemCallback to use null for deletion instead of zero
• fade-out substract button when amount equals zero

New functionality

fade-out name when amount equals zero

Changed & removed functionality

substracting when zero no longer delete item. it pushes you to use the dedicated button to do that (wanted to add a toaster notification but felt a bit out of scope).

[Abrynos]

As per my comment on issue #106 :

please make sure it's behind a new setting

[tharvik]

As per my comment on issue #106 :

yeah, it's kinda hard to know which issues are relevant to a wanted features as all are closed. consider keeping some open, eventough you don't intend to work on it personnally, as to avoid newcomers opening the same issue (#40, #44, #51, #55, ~#75, #106 in this case) and external contributors to have a clearer summary of what is wanted.

please make sure it's behind a new setting

added. it's a bit weird to handle both use-cases, as two buttons have the same action on an item with an amount of one (minus and delete). also, when changing the crossout setting, I didn't find a nice way to refresh the presentation of the items in the main activity so until the amount change, it keeps the previous style. maybe you have an idea?

[Abrynos]

when changing the crossout setting, I didn't find a nice way to refresh the presentation of the items in the main activity so until the amount change, it keeps the previous style. maybe you have an idea?

You just gave me a headache because that reminded me of the colour-switch and all the brain-cells I lost making that work. I just changed my mind about having it as a setting (really sorry for the extra work). Feel free to remove that again.

[Abrynos]

However, it would be nice to have a boolean-setting named "Order zero-count items last" in order to move them to the bottom of the list. Boolean because non-zero items should still follow default sorting order.

[tharvik]

when changing the crossout setting

You just gave me a headache because that reminded me of the colour-switch and all the brain-cells I lost making that work. I just changed my mind about having it as a setting (really sorry for the extra work). Feel free to remove that again.

haa yes, android is quite cumbersome to work with. I removed it or rather, I changed it into a boolean switch for sorting zero-count items to the bottom, as you suggested. as such, fadeout of zero-count items name (and minus-button) is always on. and as the sorting option wasn't actually, well, sorting, so I implemented it.

[Abrynos]

Also feel free to mention yourself in fastlane/metadata/android/en-US/changelogs/17.txt 😉

[tharvik]

Also feel free to mention yourself in fastlane/metadata/android/en-US/changelogs/17.txt 😉

haha, added in latest commit :)

[Abrynos]

Thank you for your contribution 🏆