Remove log4j.properties from packaged jar

AbsaOSS / ABRiS

Avro SerDe for Apache Spark structured APIs.

Apache License 2.0

230 stars 75 forks source link

Remove log4j.properties from packaged jar #205

Closed froesef closed 3 years ago

froesef commented 3 years ago

Currently the released jar file includes a log4j.properties file. This may disturb logging configuration of projects that are using it. I see that there is example code in the library as well that is using this and it's easier to have a logger configuration file in order to run these examples.

What do you think about excluding the properties file in the last step when building the jar? So that for tests etc it would be there but it would not be in the final jar that is uploaded to maven.

cerveada commented 3 years ago

That makes sense.

But I don't think we should use a variable for scope like that. If you need it to run in IDE. There should be a way to configure it there. For example Idea has that option here:

Screenshot 2021-03-25 at 09 10 30